Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foxy] print RCL_LOCALHOST_ENV_VAR if error happens via rcutils_get_env. (#672) #675

Merged
merged 1 commit into from
Jun 8, 2020
Merged

[Foxy] print RCL_LOCALHOST_ENV_VAR if error happens via rcutils_get_env. (#672) #675

merged 1 commit into from
Jun 8, 2020

Conversation

ivanpauno
Copy link
Member

Backports #672 to Foxy.

@fujitatomoya
print RCL_LOCALHOST_ENV_VAR if error happens via rcutils_get_env. (#672)
1cff651 
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@ivanpauno ivanpauno self-assigned this Jun 8, 2020
@ivanpauno ivanpauno changed the base branch from master to foxy June 8, 2020 13:02
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Jun 8, 2020
@dirk-thomas
Copy link
Member

This should be --ff-only instead to avoid diverging foxy from master while we can.

@ivanpauno
Copy link
Member Author

This should be --ff-only instead to avoid diverging foxy from master while we can.

I will do a merge fast-forward of this PR, the commit hash is exactly the same that the one on master. I opened this, so I get a previous approval of doing the backport.

DCO will fail, as if I sign the commit it will change the hash (though, I don't think that cherry-picked commits need to be re-signed).

@ivanpauno
Copy link
Member Author

@jacobperron the PR checker doesn't seem to be working correctly.

@jacobperron
Copy link
Member

@ros-pull-request-builder retest this please

@dirk-thomas dirk-thomas closed this Jun 8, 2020
@dirk-thomas dirk-thomas reopened this Jun 8, 2020
@jacobperron
Copy link
Member

I don't know what's up the the PR job. Could be an issue with Jenkins. Other than this PR, we haven't had any PR jobs triggered within the last 20 hours.

@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please (after wiping the workspace)

@ivanpauno ivanpauno merged commit 1cff651 into foxy Jun 8, 2020
@wjwwood wjwwood deleted the ivanpauno/backport-#672 branch April 22, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivanpauno @dirk-thomas @jacobperron @fujitatomoya